Skip to content

Comments

feat: enforce PR title convention and description requirements in CI#240

Closed
Xoulomon wants to merge 2 commits intoMindBlockLabs:mainfrom
Xoulomon:feature/add-pr-validation-ci
Closed

feat: enforce PR title convention and description requirements in CI#240
Xoulomon wants to merge 2 commits intoMindBlockLabs:mainfrom
Xoulomon:feature/add-pr-validation-ci

Conversation

@Xoulomon
Copy link

@Xoulomon Xoulomon commented Feb 20, 2026

This PR implements automated PR quality validation in the CI/CD pipeline to ensure all pull requests meet minimum quality standards which closes #234

Changes Made

  • Added validate-pr job to .github/workflows/ci.yml that checks:
    • PR title follows Conventional Commits format with minimum 10 characters
    • PR description contains at least 15 words
    • Branch name follows feature/*, fix/*, or docs/* convention
  • Updated CONTRIBUTING.md with comprehensive PR quality guidelines
  • Added PR_VALIDATION_GUIDE.md with testing instructions and examples

Testing

The validation logic has been tested locally. A separate test PR will be created to verify the CI integration works correctly.

@Xoulomon
feat: enforce PR title convention and description requirements in CI
5f1d6e3 
- Add validate-pr job to check PR title format (Conventional Commits)
- Validate PR description has minimum 15 words
- Validate branch naming follows feature/fix/docs convention
- Update CONTRIBUTING.md with PR quality standards
- Add PR validation testing guide
@Xoulomon
Copy link
Author

Xoulomon commented Feb 20, 2026

Hey @phertyameen , Just created a PR, do approval workflow ASAP , so if everything checks and PR merged , i can create another PR to test CI checks i implemented.

Thanks

phertyameen
phertyameen reviewed Feb 20, 2026
View reviewed changes
Copy link
Member

@phertyameen phertyameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pr title looks good to me. Check your ci/cd for excessiveness. We wouldn't want to stress contributors with annooying checks

@Xoulomon
Copy link
Author

Xoulomon commented Feb 20, 2026

Your pr title looks good to me. Check your ci/cd for excessiveness. We wouldn't want to stress contributors with annooying checks

okay will make fixes

@Xoulomon
Copy link
Author

Xoulomon commented Feb 20, 2026

hey @phertyameen ,

You can check it now

phertyameen
phertyameen reviewed Feb 20, 2026
View reviewed changes
Copy link
Member

@phertyameen phertyameen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see any cicd file. I only sugessted to minimise the restrictions not remove the entire workflow that actually handles the issue

.github/PR_VALIDATION_GUIDE.md
Copy link
Member

@phertyameen phertyameen Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was not in the issue description. Again, delete it.

@Xoulomon Xoulomon closed this Feb 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phertyameen phertyameen phertyameen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enforce PR Title Convention & Description Requirements in CI/CD Pipeline

3 participants

@Xoulomon @phertyameen @XOUL-LABS